aloyszhang commented on a change in pull request #13796:
URL: https://github.com/apache/pulsar/pull/13796#discussion_r817292184
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdNamespaces.java
##########
@@ -878,10 +878,15 @@ void run() throws PulsarAdminException {
private boolean unload;
@Parameter(names = { "--split-algorithm-name", "-san" }, description =
"Algorithm name for split "
- + "namespace bundle. Valid options are: [range_equally_divide,
topic_count_equally_divide]."
- + " Use broker side config if absent", required = false)
+ + "namespace bundle. Valid options are: [range_equally_divide,
topic_count_equally_divide, "
+ + "specified_positions_divide]. Use broker side config if
absent", required = false)
private String splitAlgorithmName;
+ @Parameter(names = { "--split-boundaries",
Review comment:
Yes, it's a comma-separated parameter.
> I think we should add an example here?
Do you know where is the right place we can add an CLI example? I didn't
find any example right now
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdNamespaces.java
##########
@@ -878,10 +878,15 @@ void run() throws PulsarAdminException {
private boolean unload;
@Parameter(names = { "--split-algorithm-name", "-san" }, description =
"Algorithm name for split "
- + "namespace bundle. Valid options are: [range_equally_divide,
topic_count_equally_divide]."
- + " Use broker side config if absent", required = false)
+ + "namespace bundle. Valid options are: [range_equally_divide,
topic_count_equally_divide, "
+ + "specified_positions_divide]. Use broker side config if
absent", required = false)
private String splitAlgorithmName;
+ @Parameter(names = { "--split-boundaries",
Review comment:
Yes, it's a comma-separated parameter.
> I think we should add an example here?
Do you know where is the right place we can add an CLI example? I didn't
find any example right now
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdNamespaces.java
##########
@@ -878,10 +878,15 @@ void run() throws PulsarAdminException {
private boolean unload;
@Parameter(names = { "--split-algorithm-name", "-san" }, description =
"Algorithm name for split "
- + "namespace bundle. Valid options are: [range_equally_divide,
topic_count_equally_divide]."
- + " Use broker side config if absent", required = false)
+ + "namespace bundle. Valid options are: [range_equally_divide,
topic_count_equally_divide, "
+ + "specified_positions_divide]. Use broker side config if
absent", required = false)
private String splitAlgorithmName;
+ @Parameter(names = { "--split-boundaries",
Review comment:
Yes, it's a comma-separated parameter.
> I think we should add an example here?
Do you know where is the right place we can add a CLI example? I didn't
find any example right now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
