mattisonchao commented on pull request #14367: URL: https://github.com/apache/pulsar/pull/14367#issuecomment-1056482122
@codelipenghui @eolivelli @michaeljmarshall @Technoboy- After deep think, I think we just have two-point can make the subscription still exist after the health check: 1. Throw an error before closing the reader. 2. Delete subscription fails after closing reader. So we can use another method to fix that issues to avoid using the non-thread-safe cleaner: 1. Use ``Completable#handle`` to fix problem 1, the reader needs to be closed regardless of whether there is an exception. 2. Recheck the subscription after closing reading, and force deletion if it still exists after closing reading. Please let me know if you have any suggestions. Thanks~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
