aloyszhang commented on a change in pull request #13796:
URL: https://github.com/apache/pulsar/pull/13796#discussion_r819635071
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
##########
@@ -570,18 +571,34 @@ public void splitNamespaceBundle(
@PathParam("bundle") String bundleRange,
@QueryParam("authoritative") @DefaultValue("false") boolean
authoritative,
@QueryParam("unload") @DefaultValue("false") boolean unload,
- @QueryParam("splitAlgorithmName") String splitAlgorithmName) {
-
+ @QueryParam("splitAlgorithmName") String splitAlgorithmName,
+ @ApiParam("splitBoundaries") List<Long> splitBoundaries) {
try {
validateNamespaceName(tenant, namespace);
- internalSplitNamespaceBundle(asyncResponse, bundleRange,
authoritative, unload, splitAlgorithmName);
+ internalSplitNamespaceBundle(asyncResponse,
+ bundleRange, authoritative, unload, splitAlgorithmName,
splitBoundaries);
} catch (WebApplicationException wae) {
asyncResponse.resume(wae);
} catch (Exception e) {
asyncResponse.resume(new RestException(e));
}
}
+ @GET
+ @Path("/{tenant}/{namespace}/{bundle}/topicHashPositions")
+ @ApiOperation(value = "Get hash positions for topics")
+ @ApiResponses(value = {
+ @ApiResponse(code = 403, message = "Don't have admin permission"),
+ @ApiResponse(code = 404, message = "Namespace does not exist")})
+ public TopicHashPositions getTopicHashPositions(
+ @PathParam("tenant") String tenant,
+ @PathParam("namespace") String namespace,
+ @PathParam("bundle") String bundleRange,
+ @QueryParam("topicList") List<String> topicList) {
Review comment:
> The topicList should be in the request body? Too many topic names
might reach the length limitation of the URL.
This is a `GET` method, seems the `AsyncInvoker` has no way to set a body
for the `GET` method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
