lhotari commented on a change in pull request #13740:
URL: https://github.com/apache/pulsar/pull/13740#discussion_r820520188
##########
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/util/SecurityUtility.java
##########
@@ -518,51 +540,18 @@ private static void
setupClientAuthentication(SslContextBuilder builder,
}
}
- public static SslContextFactory createSslContextFactory(boolean
tlsAllowInsecureConnection,
- String tlsTrustCertsFilePath, String tlsCertificateFilePath,
String tlsKeyFilePath,
- boolean tlsRequireTrustedClientCertOnConnect, boolean autoRefresh,
long certRefreshInSec)
- throws GeneralSecurityException, SSLException,
FileNotFoundException, IOException {
- SslContextFactory sslCtxFactory = null;
- if (autoRefresh) {
- sslCtxFactory = new
SslContextFactoryWithAutoRefresh(tlsAllowInsecureConnection,
tlsTrustCertsFilePath,
- tlsCertificateFilePath, tlsKeyFilePath,
tlsRequireTrustedClientCertOnConnect, 0);
- } else {
- sslCtxFactory = new SslContextFactory();
- SSLContext sslCtx = createSslContext(tlsAllowInsecureConnection,
tlsTrustCertsFilePath,
- tlsCertificateFilePath, tlsKeyFilePath);
- sslCtxFactory.setSslContext(sslCtx);
- }
- if (tlsRequireTrustedClientCertOnConnect) {
- sslCtxFactory.setNeedClientAuth(true);
- } else {
- sslCtxFactory.setWantClientAuth(true);
+ private static Provider resolveProvider(String providerName) throws
NoSuchAlgorithmException {
+ if (StringUtils.isEmpty(providerName)) {
Review comment:
Yes, it's intended to be used whenever we use Jetty. See #10372 for the
original motivation.
I noticed that the "tlsProvider" field is missing from
WebSocketProxyConfiguration class. I'd assume that the tlsProvider field would
be set to "Conscrypt" for all 3 classes: ServiceConfiguration,
ProxyConfiguration and WebSocketProxyConfiguration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
