dlg99 opened a new pull request #14589:
URL: https://github.com/apache/pulsar/pull/14589


   ### Motivation
   
   The sink does not crash (thus leaves no chance for auto restart in k8s) if 
the connector throws exception on write.
   Specific case was caused by ElasticSearch connector; teh es client lost 
connection and could not recover it without restart, and got stuck not 
processing anything until human interaction (restart via cli)
   
   The root cause traces to sendOutputMessage not re-throwing exception after 
it failed the record.
   
   
https://github.com/apache/pulsar/blob/0f72a4ff1f21ecf9815290a78be2ab2ea48cecc7/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java#L356-L370
   
   ### Modifications
   
   Cherry-picked couple of changes:
   
   The problem was fixed in 
[#12278](https://github.com/apache/pulsar/pull/12278)
   
   To avoid redoing the changes ro dealing with conflicts I also picked 
https://github.com/apache/pulsar/pull/11618 
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
   Check the box below or label this PR directly (if you have committer 
privilege).
   
   Need to update docs? 
   
   - [ ] `doc-required` 
     
     (If you need help on updating docs, create a doc issue)
     
   - [x] `no-need-doc` 
     
     (Please explain why)
     
   - [ ] `doc` 
     
     (If this PR contains doc changes)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to