HQebupt commented on pull request #13563: URL: https://github.com/apache/pulsar/pull/13563#issuecomment-1061700445
> > LGTM. > > @HQebupt - thanks for the reference. Do you know which versions of Pulsar need this patch? > > @michaeljmarshall This applies to all Pulsar versions since v1.21.0-incubating. The `-Dio.netty.recycler.maxCapacity.default=1000` setting stopped working after Netty 4.1 upgrade in #689 ([v1.21.0-incubating](https://github.com/apache/pulsar/releases/tag/v1.21.0-incubating)). The effective setting has been `-Dio.netty.recycler.maxCapacityPerThread=4096` so that's why it makes sense to either remove the setting completely (as suggested in #14576) or replace all occurrences of `-Dio.netty.recycler.maxCapacity.default=1000` with `-Dio.netty.recycler.maxCapacityPerThread=4096` in all source files (including documentation). Sure, let me do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
