Technoboy- commented on pull request #14618: URL: https://github.com/apache/pulsar/pull/14618#issuecomment-1063580105
> @Technoboy- I little suggestion for the future: when you cherry pick a patch from someone else it is a good practice to start by cherry picking the original patch and try to keep the original author, otherwise it seems that you are the original author, in this case it is @mattisonchao > > I am looking here https://github.com/apache/pulsar/pull/14618/commits > > this is the original commit [4f1e39b](https://github.com/apache/pulsar/commit/4f1e39b6921ea401b8c27f17a041d06d85f8abf8) > > it is fine to amend it and adapt it to the target branch, but my point is that in the git history @mattisonchao should be listed as author of the patch (whenever it is possible). Yes, I see. Thanks. But there are a lot of conflicts when cherry-picking. So I have to rewrite it according to the original one. We can add the author info when merging. (I'm not for any commits record here, but for speeding up the release.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
