michaeljmarshall edited a comment on issue #13429:
URL: https://github.com/apache/pulsar/issues/13429#issuecomment-1063638706
The `pulsar-client-cpp/CMakeLists.txt` looks like it could matter. Here is
the diff:
```diff
mmarshall-rmbp16:pulsar michaelmarshall$ git diff v2.9.2-candidate-1..v2.8.3
pulsar-client-cpp/CMake*
diff --git a/pulsar-client-cpp/CMakeLists.txt
b/pulsar-client-cpp/CMakeLists.txt
index 3fadb05a092..251d4860202 100644
--- a/pulsar-client-cpp/CMakeLists.txt
+++ b/pulsar-client-cpp/CMakeLists.txt
@@ -99,7 +99,7 @@ else() # GCC or Clang are mostly compatible:
# Options unique to Clang or GCC:
if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
add_compile_options(-Qunused-arguments)
- elseif (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND NOT
(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 4.9))
+ elseif (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND NOT
(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 8.1))
add_compile_options(-Wno-stringop-truncation)
endif()
endif()
@@ -139,12 +139,12 @@ unset(OPENSSL_VERSION CACHE)
if (LINK_STATIC)
find_library(ZLIB_LIBRARIES REQUIRED NAMES libz.a z zlib)
- find_library(Protobuf_LIBRARIES NAMES libprotobuf.a libprotobuf)
+ find_library(Protobuf_LITE_LIBRARIES NAMES libprotobuf-lite.a
libprotobuf-lite)
find_library(CURL_LIBRARIES NAMES libcurl.a curl curl_a libcurl_a)
find_library(LIB_ZSTD NAMES libzstd.a)
find_library(LIB_SNAPPY NAMES libsnappy.a)
- message(STATUS "Protobuf_LIBRARIES: ${Protobuf_LIBRARIES}")
- set(COMMON_LIBS ${Protobuf_LIBRARIES} ${COMMON_LIBS})
+ message(STATUS "Protobuf_LITE_LIBRARIES: ${Protobuf_LITE_LIBRARIES}")
+ set(COMMON_LIBS ${Protobuf_LITE_LIBRARIES} ${COMMON_LIBS})
if (USE_LOG4CXX)
if (LOG4CXX_USE_DYNAMIC_LIBS)
@@ -179,30 +179,28 @@ else()
find_package(ZLIB REQUIRED)
set(ZLIB_LIBRARIES ${ZLIB_LIBRARIES})
# NOTE: The default MODULE mode may not find debug libraries so use
CONFIG mode here
- unset(Protobuf_INCLUDE_DIRS CACHE)
- unset(Protobuf_LIBRARIES CACHE)
find_package(Protobuf QUIET CONFIG)
# NOTE: On Windows x86 platform, Protobuf_FOUND might be set false but
Protobuf_INCLUDE_DIRS and
- # Protobuf_LIBRARIES are both found.
- if (Protobuf_INCLUDE_DIRS AND Protobuf_LIBRARIES AND NOT Protobuf_FOUND)
+ # Protobuf_LITE_LIBRARIES are both found.
+ if (Protobuf_INCLUDE_DIRS AND Protobuf_LITE_LIBRARIES AND NOT
Protobuf_FOUND)
set(Protobuf_FOUND TRUE)
endif ()
if (Protobuf_FOUND)
message("Found Protobuf in config mode")
- message(STATUS "Protobuf_LIBRARIES: ${Protobuf_LIBRARIES}")
+ message(STATUS "Protobuf_LITE_LIBRARIES:
${Protobuf_LITE_LIBRARIES}")
message(STATUS "Protobuf_INCLUDE_DIRS: ${Protobuf_INCLUDE_DIRS}")
else ()
message("Failed to find Protobuf in config mode, try to find it
from system path")
- find_library(Protobuf_LIBRARIES protobuf libprotobuf)
+ find_library(Protobuf_LITE_LIBRARIES protobuf-lite libprotobuf-lite)
find_path(Protobuf_INCLUDE_DIRS google/protobuf/stubs/common.h)
- message(STATUS "Protobuf_LIBRARIES: ${Protobuf_LIBRARIES}")
+ message(STATUS "Protobuf_LITE_LIBRARIES:
${Protobuf_LITE_LIBRARIES}")
message(STATUS "Protobuf_INCLUDE_DIRS: ${Protobuf_INCLUDE_DIRS}")
endif ()
if (${Protobuf_FOUND} AND (${CMAKE_VERSION} VERSION_GREATER 3.8))
- set(COMMON_LIBS protobuf::libprotobuf ${COMMON_LIBS})
+ set(COMMON_LIBS protobuf::libprotobuf-lite ${COMMON_LIBS})
else ()
- set(COMMON_LIBS ${Protobuf_LIBRARIES} ${COMMON_LIBS})
+ set(COMMON_LIBS ${Protobuf_LITE_LIBRARIES} ${COMMON_LIBS})
endif ()
if (MSVC AND (${CMAKE_BUILD_TYPE} STREQUAL Debug))
@@ -459,4 +457,4 @@ add_custom_target(check-format python
${BUILD_SUPPORT_DIR}/run_clang_format.py
${CMAKE_SOURCE_DIR}/examples
${CMAKE_SOURCE_DIR}/tests
${CMAKE_SOURCE_DIR}/include
- ${CMAKE_SOURCE_DIR}/python/src)
+ ${CMAKE_SOURCE_DIR}/python/src)
\ No newline at end of file
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
