oversearch commented on issue #13429:
URL: https://github.com/apache/pulsar/issues/13429#issuecomment-1063663439


   Hi all, 
   
   I think this may be due to my change to enable warnings as errors in the c++ 
client.  I tested on GCC, Clang, and Visual Studio... but I don't have a Mac to 
test with and I'm guessing the OSX compiler is different (not sure what 
`AppleClang` is... I have zero experience with macs).  The error message states 
that it doesn't know the option `-Werror=cpp`.  I think if you simply strip 
that flag out of from the `CMakeLists.txt` file, this will go away for you.  
   
   Ideally we'd add another branch for AppleClang that has the proper flag so 
that this works, because warnings as errors is a valuable tool for hardening 
any C++ code base.  Although given the range of compliers y'all need to 
support, maybe it's more trouble than it's worth... my experience is mostly 
with big commercial code bases where there's only one or two compilers that 
need to be supported.
   
   Sorry for the inconvenience here!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to