Jason918 commented on a change in pull request #14608:
URL: https://github.com/apache/pulsar/pull/14608#discussion_r824383724



##########
File path: 
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java
##########
@@ -632,14 +632,10 @@ void run() throws Exception {
                 "--force" }, description = "Close all 
producer/consumer/replicator and delete topic forcefully")
         private boolean force = false;
 
-        @Parameter(names = { "-d",

Review comment:
       > hide `-d` rather than remove for compatibility, then declare that this 
parameter is invalid and the new behavior.
   
   Yes, I think it's better this way. Hide the parameter and print a warning 
log if user set this "-d false" explicitly.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to