Jason918 commented on a change in pull request #12025:
URL: https://github.com/apache/pulsar/pull/12025#discussion_r824430480
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/resources/BaseResources.java
##########
@@ -43,6 +43,7 @@
protected static final String BASE_POLICIES_PATH = "/admin/policies";
protected static final String BASE_CLUSTERS_PATH = "/admin/clusters";
+ protected static final String LOCAL_POLICIES_ROOT =
"/admin/local-policies";
Review comment:
We should remove `LocalPoliciesResources#LOCAL_POLICIES_ROOT`
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/bookie/rackawareness/IsolatedBookieEnsemblePlacementPolicy.java
##########
@@ -59,6 +58,8 @@
private MetadataCache<BookiesRackConfiguration> bookieMappingCache;
+ private static final String PULSAR_METADATA_ISOLATION_GROUP = "*";
Review comment:
This name is a little confusing, any better choice?
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/bookie/rackawareness/IsolatedBookieEnsemblePlacementPolicy.java
##########
@@ -200,6 +223,9 @@ private static String castToString(Object obj) {
private Set<BookieId> getBlacklistedBookiesWithIsolationGroups(int
ensembleSize,
Pair<Set<String>, Set<String>> isolationGroups) {
Set<BookieId> blacklistedBookies = new HashSet<>();
+ if (isolationGroups != null &&
isolationGroups.getLeft().contains(PULSAR_METADATA_ISOLATION_GROUP)) {
Review comment:
Can we set `PULSAR_METADATA_ISOLATION_GROUP` in
`secondaryIsolationBookieGroups`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
