Technoboy- commented on pull request #14643: URL: https://github.com/apache/pulsar/pull/14643#issuecomment-1065817513
For convenient review, a little explanation here: Move preCreateSubscriptionForCompactionIfNeeded after initialize. because in preCreateSubscriptionForCompactionIfNeeded it will retrieve the compaction threshold, it could only get the value at the broker level. Only after initialize, namespace and topic level values will load into the topic. So it's the reason to do this. Besides, I think preCreateSubscriptionForCompactionIfNeeded should stay after initialize is more accurate . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
