yuruguo commented on a change in pull request #14655:
URL: https://github.com/apache/pulsar/pull/14655#discussion_r825520065



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistry.java
##########
@@ -37,7 +37,7 @@
     CompletableFuture<SchemaVersion> putSchemaIfAbsent(String schemaId, 
SchemaData schema,
                                                        
SchemaCompatibilityStrategy strategy);
 
-    CompletableFuture<SchemaVersion> deleteSchema(String schemaId, String 
user);
+    CompletableFuture<SchemaVersion> deleteSchema(String schemaId, String 
user, boolean force);

Review comment:
       Should we remain method `deleteSchema(String schemaId, String user)` 
then add new method `deleteSchema(String schemaId, String user, boolean force)`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to