lordcheng10 commented on a change in pull request #13679:
URL: https://github.com/apache/pulsar/pull/13679#discussion_r826532790
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/EntryCacheManager.java
##########
@@ -45,9 +45,9 @@
@SuppressWarnings("checkstyle:javadoctype")
public class EntryCacheManager {
- private final long maxSize;
- private final long evictionTriggerThreshold;
- private final double cacheEvictionWatermark;
+ private volatile long maxSize;
+ private volatile long evictionTriggerThreshold;
+ private volatile double cacheEvictionWatermark;
Review comment:
> do you have a use case that shows why the benefits out way the costs
here?
If we need to adjust the cache parameters, we need to restart the online
cluster in turn. Restarting the cluster will have a certain impact on online
business.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
