Shawyeok commented on a change in pull request #14377:
URL: https://github.com/apache/pulsar/pull/14377#discussion_r826547320
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
##########
@@ -1907,18 +1907,17 @@ protected void completeOpBatchReceive(OpBatchReceive<T>
op) {
return CompletableFuture.completedFuture(Collections.emptyList());
}
List<MessageIdData> data = new ArrayList<>(messageIds.size());
Review comment:
There are seem another potential race condition, use `ArrayList` in
possible `multithread` scenario is unsafe.
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
##########
@@ -1907,18 +1907,17 @@ protected void completeOpBatchReceive(OpBatchReceive<T>
op) {
return CompletableFuture.completedFuture(Collections.emptyList());
}
List<MessageIdData> data = new ArrayList<>(messageIds.size());
Review comment:
I've create #14687 to continue this discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
