shileiyu opened a new pull request #750:
URL: https://github.com/apache/pulsar-client-go/pull/750


   …rrentBatches if the associated batch builder contains multi 
batches(KeyBasedBatchBuilder).
   
   Doing transparent forwarding could centralized the branching logic at only 
one place.
   
   <--
   ### Contribution Checklist
     
     - Name the pull request in the form "[Issue XYZ][component] Title of the 
pull request", where *XYZ* should be replaced by the actual issue number.
       Skip *Issue XYZ* if there is no associated github issue for this pull 
request.
       Skip *component* if you are unsure about which is the best component. 
E.g. `[docs] Fix typo in produce method`.
   
     - Fill out the template below to describe the changes contributed by the 
pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from 
multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and 
this checklist, leaving only the filled out template below.
   -->
   
   Fixes #749 
   
   ### Motivation
   Eliminating multiple identical patches, which branch to the correct internal 
function by checking the type of associated batch builder.
   
   ### Modifications
   
   Calling internalFlushCurrentBatch will be forwarded to 
internalFlushCurrentBatches if the associated batch builder contains multiple 
batches(e.g. KeyBasedBatchBuilder). 
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   This change is already covered by existing integration tests.
   
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads 
(10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   None
   
   ### Documentation
   
   Not required


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to