eolivelli commented on a change in pull request #14709:
URL: https://github.com/apache/pulsar/pull/14709#discussion_r828839374
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TransactionTest.java
##########
@@ -802,7 +802,7 @@ public void testCancelTxnTimeout() throws Exception{
public void
testNotChangeMaxReadPositionAndAddAbortTimesWhenCheckIfNoSnapshot() throws
Exception {
PersistentTopic persistentTopic = (PersistentTopic)
getPulsarServiceList().get(0)
.getBrokerService()
- .getTopic(NAMESPACE1 + "/test", true)
+ .getTopic(NAMESPACE1 +
"/changeMaxReadPositionAndAddAbortTimes", true)
Review comment:
you can add some suffix (UUID.randomUUID) in order to not reuse the same
topic in case of test that is re-run due to a failure
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java
##########
@@ -179,6 +179,9 @@ public void handleTxnEntry(Entry entry) {
@Override
public void recoverExceptionally(Exception e) {
+ if (e instanceof
PulsarClientException.BrokerMetadataException) {
Review comment:
can we add a log line here ? like "Closing topic {} due to {} while
recovering the transaction buffer"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
