Technoboy- commented on a change in pull request #14729:
URL: https://github.com/apache/pulsar/pull/14729#discussion_r829076250
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ReaderBuilderImpl.java
##########
@@ -229,4 +230,26 @@ private ReaderBuilderImpl(PulsarClientImpl client,
ReaderConfigurationData<T> co
conf.setPoolMessages(poolMessages);
return this;
}
+
+ @Override
+ public ReaderBuilder<T> autoUpdatePartitions(boolean autoUpdate) {
+ this.conf.setAutoUpdatePartitions(autoUpdate);
+ return this;
+ }
+
+ @Override
+ public ReaderBuilder<T> autoUpdatePartitionsInterval(int interval,
TimeUnit unit) {
+ checkArgument(interval > 0, "interval needs to be > 0");
Review comment:
Do we need to keep this value at least 1 minute?
If user configs with 1ms, then what happens ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
