madhavan-narayanan commented on pull request #14613: URL: https://github.com/apache/pulsar/pull/14613#issuecomment-1071943693
> @madhavan-narayanan Maybe we could add a new param `Object context` for method `onPulsarCommand` to make it‘s suitable for more cases. I'm concerned that we need to add too many events in `BrokerInterceptor`. @gaoran10 , I understand your concern. I can add another overloaded method for 'onPulsarCommand' with additional 'context' parameter to avoid proliferation of callbacks in the future. But is the opaque 'Object context' any concern? Developers implementing the interceptor have to understand the structure and semantics of the context by browsing the broker code or from the documentation of 'onPulsarCommand' which I am afraid can become unwieldy and ambiguous later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
