jerrypeng opened a new pull request #3934: fix submit function via url
URL: https://github.com/apache/pulsar/pull/3934
 
 
   ### Motivation
   
   Submitting a function in which the function package is a url is broker right 
now.  If a user is submitting a function with a url package, he or she will get 
the following exception:
   
   ```
   Jerrys-MBP:incubator-pulsar jerrypeng$ ./bin/pulsar-admin functions create 
--function-config-file ~/function.yaml 
   User class must be in class path
   
   Reason: User class must be in class path
   ```
   
   The reason is because we don't actually download the function package from 
the URL and load it
   
   
   ### Modifications
   
   Download the JAR from the function package URL.
   
   I am not sure why in the code we only download the first 10 bytes from the 
URL and then delete the file.  Was this just to check if the URL is valid? 
   
   Maybe @rdhabalia can chime in since he wrote most of this code originally.
   
   Though not sure we should download the function package/JAR so that we can 
do some validation.  The JAR can be very large.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to