nlu90 commented on a change in pull request #14450:
URL: https://github.com/apache/pulsar/pull/14450#discussion_r829289750
##########
File path: conf/functions_worker.yml
##########
@@ -26,6 +26,13 @@ workerHostname: localhost
workerPort: 6750
workerPortTls: 6751
+# The metadata store URL
+# Examples:
+# * zk:my-zk-1:2181,my-zk-2:2181,my-zk-3:2181
+# * my-zk-1:2181,my-zk-2:2181,my-zk-3:2181 (will default to ZooKeeper when the
schema is not specified)
+# * zk:my-zk-1:2181,my-zk-2:2181,my-zk-3:2181/my-chroot-path (to add a ZK
chroot path)
+metadataStoreUrl: zk:localhost:2181
Review comment:
what's the difference with the following `configurationMetadataStoreUrl`?
##########
File path: conf/functions_worker.yml
##########
@@ -45,6 +52,10 @@ metadataStoreCacheExpirySeconds: 300
################################
# Function package management
################################
+packagesManagementStorageProvider:
+
org.apache.pulsar.packages.management.storage.bookkeeper.BookKeeperPackagesStorageProvider
+packagesManagementLedgerRootPath: /ledgers
+packagesReplicas: 1
Review comment:
`broker.conf` and `standalone.conf` also have these same configurations.
If you added them here, what's the relationship between these duplicated
configuration?
Do you want to remove them from other conf files or they will have some
override relationship?
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##########
@@ -780,14 +780,14 @@ public void start() throws PulsarServerException {
acquireSLANamespace();
- // start function worker service if necessary
- this.startWorkerService(brokerService.getAuthenticationService(),
brokerService.getAuthorizationService());
-
// start packages management service if necessary
if (config.isEnablePackagesManagement()) {
this.startPackagesManagementService();
}
Review comment:
If you make function worker depend on package management service, then
shouldn't the package management service be always enabled when function worker
is enabled?
Currently it seems they are separately configured, which may result the case
that function worker is enabled but package management service is not running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
