michaeljmarshall commented on a change in pull request #14713:
URL: https://github.com/apache/pulsar/pull/14713#discussion_r831284455
##########
File path:
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java
##########
@@ -458,25 +459,6 @@ protected void handleLookup(CommandLookupTopic lookup) {
lookupProxyHandler.handleLookup(lookup);
}
- private synchronized void close() {
- if (state != State.Closed) {
- state = State.Closed;
- if (directProxyHandler != null &&
directProxyHandler.outboundChannel != null) {
- directProxyHandler.outboundChannel.close();
- directProxyHandler = null;
- }
- if (connectionPool != null) {
- try {
- connectionPool.close();
Review comment:
I was wondering if we needed to call close here, but looks like that'll
happen in the `channelInactive` method that netty will call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
