codelipenghui commented on a change in pull request #14781:
URL: https://github.com/apache/pulsar/pull/14781#discussion_r831730765
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/MLPendingAckStore.java
##########
@@ -398,7 +398,7 @@ public Entry get() {
public void readEntriesFailed(ManagedLedgerException exception, Object
ctx) {
if (managedLedger.getConfig().isAutoSkipNonRecoverableData()
&& exception instanceof
ManagedLedgerException.NonRecoverableLedgerException
- || exception instanceof
ManagedLedgerException.ManagedLedgerFencedException) {
Review comment:
And from the current implementation, if return `isReadable` here which
means the pending ack reply will be complete, is it expected behavior?
https://github.com/apache/pulsar/pull/14781/files#diff-07a1d142ec4105cb65fac733494182b461214a68d735ae1c3f5104c3eb4f92dbL363
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/MLPendingAckStore.java
##########
@@ -398,7 +398,7 @@ public Entry get() {
public void readEntriesFailed(ManagedLedgerException exception, Object
ctx) {
if (managedLedger.getConfig().isAutoSkipNonRecoverableData()
&& exception instanceof
ManagedLedgerException.NonRecoverableLedgerException
- || exception instanceof
ManagedLedgerException.ManagedLedgerFencedException) {
Review comment:
Why remove the `ManagedLedgerFencedException` check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
