asardaes commented on a change in pull request #14798:
URL: https://github.com/apache/pulsar/pull/14798#discussion_r832508322
##########
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/util/TrustManagerProxy.java
##########
@@ -74,11 +76,16 @@ private void updateTrustManager() throws
CertificateException, KeyStoreException
FileNotFoundException, IOException {
CertificateFactory factory = CertificateFactory.getInstance("X.509");
try (InputStream inputStream = new
FileInputStream(certFile.getFileName())) {
- X509Certificate certificate = (X509Certificate)
factory.generateCertificate(inputStream);
- String alias = certificate.getSubjectX500Principal().getName();
KeyStore keyStore = KeyStore.getInstance("JKS");
Review comment:
Any particular reason JKS is hardcoded instead of using the JVM's
default type?
```suggestion
KeyStore keyStore =
KeyStore.getInstance(KeyStore.getDefaultType());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
