jerrypeng commented on a change in pull request #3947: Support https links for Source/Sinks URL: https://github.com/apache/pulsar/pull/3947#discussion_r270534556
########## File path: pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/Utils.java ########## @@ -331,7 +332,8 @@ public static NarClassLoader extractNarClassLoader(Path archivePath, String pkgU throw new IllegalArgumentException( "Corrupt User PackageFile " + pkgUrl + " with error " + e.getMessage()); } - } else if (pkgUrl.startsWith("http")) { + } else if (pkgUrl.startsWith(org.apache.pulsar.common.functions.Utils.HTTP) Review comment: I have tested https with source and sinks work ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services