Jason918 commented on a change in pull request #13130:
URL: https://github.com/apache/pulsar/pull/13130#discussion_r833859225
##########
File path:
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java
##########
@@ -77,6 +78,8 @@
protected AbstractMetadataStore() {
this.executor = Executors
.newSingleThreadScheduledExecutor(new
DefaultThreadFactory("metadata-store"));
+ this.executorMonitor = new ExecutorMonitor(this.executor,
TimeUnit.MINUTES.toSeconds(5),
Review comment:
> why would anyone not want to have the monitoring disabled?
1. Debug purpose, so that we can attach into the process and dig deeper.
2. IMO, currently we want to add this because there are some potential
deadlock bug. Not some known issue that can not be fixed. Once we are confident
these kind of issue won't happen again, we won't need this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
