yuruguo commented on a change in pull request #14608:
URL: https://github.com/apache/pulsar/pull/14608#discussion_r833633795
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -1027,14 +1006,7 @@ public void unloadNamespaceBundlesGracefully(int
maxConcurrentUnload, boolean cl
new IllegalStateException("Delete forbidden topic is
replicated on clusters " + clusters));
}
- if (deleteSchema) {
- return t.deleteSchema().thenCompose(schemaVersion -> {
- log.info("Successfully delete topic {}'s schema of version
{}", t.getName(), schemaVersion);
- return t.delete();
- });
Review comment:
[t.delete()](https://github.com/apache/pulsar/pull/14608/files?diff=unified&w=0#diff-0210356c8a88e4efa89eb769a027fa6c166db479dbad8bbbbc704c6ed6e317f5R1009)
will delete schema by default.
details:
[delete()](https://github.com/apache/pulsar/pull/14608/files?diff=unified&w=0#diff-5edf14cc6f25857d0cfdd26b2d3b3141230ecfb0dfa95aebf7583fd76ede4c4bR1066-R1067)
->
[delete(boolean,boolean,boolean)](https://github.com/apache/pulsar/pull/14608/files?diff=unified&w=0#diff-5edf14cc6f25857d0cfdd26b2d3b3141230ecfb0dfa95aebf7583fd76ede4c4bR1098-R1100)
->
[deleteSchema()](https://github.com/apache/pulsar/pull/14608/files?diff=unified&w=0#diff-5edf14cc6f25857d0cfdd26b2d3b3141230ecfb0dfa95aebf7583fd76ede4c4bL1150-R1142)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
