[GitHub] [pulsar] RobertIndie commented on a change in pull request #14881: [Issue 14783][pulsar-broker] Fix javadoc warnings on pulsar-broker

[GitBox]

RobertIndie commented on a change in pull request #14881:
URL: https://github.com/apache/pulsar/pull/14881#discussion_r837062959



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/LoadManagerShared.java
##########
@@ -533,7 +532,7 @@ public static boolean shouldAntiAffinityNamespaceUnload(
 
     /**
      * It filters out brokers which owns topic higher than configured 
threshold at
-     * {@link ServiceConfiguration.loadBalancerBrokerMaxTopics}. <br/>
+     * {@link: ServiceConfiguration#loadBalancerBrokerMaxTopics}. <br/>

Review comment:
       The link here is also broken.
   <img width="626" alt="image" 
src="https://user-images.githubusercontent.com/16974619/160533210-cf0f4031-fa71-41a6-a13c-f443b41ef765.png";>
   
   Please help check other `@link` as well.
   

##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsGenerator.java
##########
@@ -51,7 +51,7 @@
 /**
  * Generate metrics aggregated at the namespace level and optionally at a 
topic level and formats them out
  * in a text format suitable to be consumed by Prometheus.
- * Format specification can be found at {@link 
https://prometheus.io/docs/instrumenting/exposition_formats/}
+ * Format specification can be found at @see <a 
href="https://prometheus.io/docs/instrumenting/exposition_formats/";>Exposition 
Formats</a>

Review comment:
       @see seems not working here.
   <img width="720" alt="image" 
src="https://user-images.githubusercontent.com/16974619/160538096-d1c17571-c3ce-4824-8cd8-f12fad7c6213.png";>
   We need to place it in the new line to make it work. But I don't think we 
need `@see` here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org