Technoboy- commented on a change in pull request #14876:
URL: https://github.com/apache/pulsar/pull/14876#discussion_r838161669
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v3/Transactions.java
##########
@@ -222,7 +228,24 @@ public void getPendingAckInternalStats(@Suspended final
AsyncResponse asyncRespo
@PathParam("topic") @Encoded String
encodedTopic,
@PathParam("subName") String
subName,
@QueryParam("metadata")
@DefaultValue("false") boolean metadata) {
- internalGetPendingAckInternalStats(asyncResponse, authoritative,
- TopicName.get(TopicDomain.persistent.value(), tenant,
namespace, encodedTopic), subName, metadata);
+
+ internalGetPendingAckInternalStats(authoritative,
+ TopicName.get(TopicDomain.persistent.value(), tenant,
namespace, encodedTopic), subName, metadata)
Review comment:
yes, right. Thanks for this suggestion. The topic name isn't decoded...
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v3/Transactions.java
##########
@@ -222,7 +228,24 @@ public void getPendingAckInternalStats(@Suspended final
AsyncResponse asyncRespo
@PathParam("topic") @Encoded String
encodedTopic,
@PathParam("subName") String
subName,
@QueryParam("metadata")
@DefaultValue("false") boolean metadata) {
- internalGetPendingAckInternalStats(asyncResponse, authoritative,
- TopicName.get(TopicDomain.persistent.value(), tenant,
namespace, encodedTopic), subName, metadata);
+
+ internalGetPendingAckInternalStats(authoritative,
+ TopicName.get(TopicDomain.persistent.value(), tenant,
namespace, encodedTopic), subName, metadata)
Review comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
