RobertIndie commented on a change in pull request #14968:
URL: https://github.com/apache/pulsar/pull/14968#discussion_r839312652
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BatchMessageTest.java
##########
@@ -217,7 +214,8 @@ public void
testSimpleBatchProducerWithFixedBatchTime(CompressionType compressio
consumer.close();
Producer<byte[]> producer =
pulsarClient.newProducer().topic(topicName).compressionType(compressionType)
- .batchingMaxPublishDelay(10,
TimeUnit.MILLISECONDS).enableBatching(true)
+ .batchingMaxPublishDelay(Integer.MAX_VALUE,
TimeUnit.MILLISECONDS)
Review comment:
We should not change here. This will cause the test to hang forever.
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BatchMessageTest.java
##########
@@ -253,7 +251,8 @@ public void
testSimpleBatchProducerWithFixedBatchSizeAndTime(CompressionType com
consumer.close();
Producer<byte[]> producer = pulsarClient.newProducer().topic(topicName)
- .batchingMaxPublishDelay(10,
TimeUnit.MILLISECONDS).batchingMaxMessages(5)
+ .batchingMaxPublishDelay(Integer.MAX_VALUE,
TimeUnit.MILLISECONDS)
Review comment:
I think 10 mills here may be intended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
