cbornet commented on a change in pull request #14948:
URL: https://github.com/apache/pulsar/pull/14948#discussion_r839442045
##########
File path:
tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/sinks/KinesisSinkTester.java
##########
@@ -18,35 +18,34 @@
*/
package org.apache.pulsar.tests.integration.io.sinks;
+import java.util.LinkedHashMap;
import lombok.SneakyThrows;
import lombok.extern.slf4j.Slf4j;
import org.apache.pulsar.tests.integration.topologies.PulsarCluster;
import org.awaitility.Awaitility;
import org.testcontainers.containers.localstack.LocalStackContainer;
import org.testcontainers.utility.DockerImageName;
import software.amazon.awssdk.auth.credentials.AwsBasicCredentials;
-import software.amazon.awssdk.auth.credentials.AwsCredentials;
-import software.amazon.awssdk.auth.credentials.AwsCredentialsProvider;
import software.amazon.awssdk.regions.Region;
import software.amazon.awssdk.services.kinesis.KinesisAsyncClient;
import software.amazon.awssdk.services.kinesis.model.CreateStreamRequest;
import software.amazon.awssdk.services.kinesis.model.GetRecordsRequest;
import software.amazon.awssdk.services.kinesis.model.GetRecordsResponse;
import software.amazon.awssdk.services.kinesis.model.GetShardIteratorRequest;
import software.amazon.awssdk.services.kinesis.model.ListShardsRequest;
-import software.amazon.awssdk.services.kinesis.model.Record;
import software.amazon.awssdk.services.kinesis.model.ShardIteratorType;
import java.net.URI;
import java.nio.charset.StandardCharsets;
import java.util.Map;
-import static org.testng.Assert.assertTrue;
+import static org.testng.Assert.assertEquals;
@Slf4j
public class KinesisSinkTester extends SinkTester<LocalStackContainer> {
private static final String NAME = "kinesis";
+ private static final int LOCALSTACK_SERVICE_PORT = 4566;
Review comment:
It is this port :
https://github.com/testcontainers/testcontainers-java/blob/0408db806f6d57b8117881adcd10b6bd6c9dcd9c/modules/localstack/src/main/java/org/testcontainers/containers/localstack/LocalStackContainer.java#L38
I didn't find an easy way to get it from Testcontainers.
It's not dynamic as we use the internal container port
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
