HQebupt commented on a change in pull request #14973:
URL: https://github.com/apache/pulsar/pull/14973#discussion_r840214328
##########
File path:
pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStore.java
##########
@@ -257,7 +257,7 @@ public void handleMetadataEntry(Position position,
TransactionMetadataEntry tran
State.Ready, getState(), "add produced partition"));
return;
}
- getTxnPositionPair(txnID).thenAccept(txnMetaListPair -> {
+ getTxnPositionPair(txnID).thenCompose(txnMetaListPair -> {
Review comment:
The origin method `getTxnPositionPair(txnID)` may throw
TransactionNotFoundException, but it does not catch it. It may cause the
uncompleted future. LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
