BewareMyPower commented on code in PR #15020:
URL: https://github.com/apache/pulsar/pull/15020#discussion_r842839160
##########
pulsar-client-cpp/lib/Commands.cc:
##########
@@ -308,6 +309,14 @@ SharedBuffer Commands::newSubscribe(const std::string&
topic, const std::string&
subscribe->mutable_metadata()->AddAllocated(keyValue);
}
+ for (std::map<std::string, std::string>::const_iterator it =
subscriptionProperties.begin();
+ it != subscriptionProperties.end(); it++) {
Review Comment:
I think we can use the C++11 style for new code. Though some legacy code
still uses older style. We can do some refactoring to these legacy code later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
