aloyszhang commented on code in PR #14488:
URL: https://github.com/apache/pulsar/pull/14488#discussion_r845322435
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java:
##########
@@ -252,23 +252,13 @@ private synchronized void refreshStats() {
lastStatTimestamp = now;
}
- private void cacheEvictionTask() {
- double evictionFrequency =
Math.max(Math.min(config.getCacheEvictionFrequency(), 1000.0), 0.001);
- long waitTimeMillis = (long) (1000 / evictionFrequency);
-
- while (true) {
- try {
- doCacheEviction();
-
- Thread.sleep(waitTimeMillis);
- } catch (InterruptedException e) {
- // Factory is shutting down
- return;
- } catch (Throwable t) {
- log.warn("Exception while performing cache eviction: {}",
t.getMessage(), t);
- }
+ Runnable cacheEvictionTask = () -> {
Review Comment:
Sounds good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
