michaeljmarshall opened a new pull request, #15077: URL: https://github.com/apache/pulsar/pull/15077
### Motivation We shouldn't print passwords, even if their environment variables have an upper case `P` (since they all do, this is an especially important fix). ### Modifications * Make the python script logic case insensitive ### Verifying this change I manually verified this by running the script before and after the change. You can observe my logs here: ``` mmarshall-rmbp16:pulsar michaelmarshall$ tlsKeyStorePassword=mysecret docker/pulsar/scripts/apply-config-from-env.py conf/broker.conf [conf/broker.conf] Applying config tlsKeyStorePassword = mysecret mmarshall-rmbp16:pulsar michaelmarshall$ tlsKeyStorePassword=mysecret docker/pulsar/scripts/apply-config-from-env.py conf/broker.conf [conf/broker.conf] Applying config tlsKeyStorePassword = ******** ``` ### Does this pull request potentially affect one of the following parts: This is a backwards compatible change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
