poorbarcode commented on PR #15051: URL: https://github.com/apache/pulsar/pull/15051#issuecomment-1092498710
> > It's just a guess at one of the possibilities for "Why #14970 problem happend". > > Because there has only one instance in , so two consumer instance has same & , so there are only two possibilities:`consumerSet``address``consumerId` > > > > * Consumer restart use same SocketAddress. > > * One consumer instance execute command-subscribe more times in a short time. > > > > After code-review on the second possibility, finds possibility-case and fixed it. > > Maybe there are other problems that can reproduce #14970 problem > > I don't think that this PR fixes that issue. ServerCnx is tied to a single TCP/IP connection and even without the changes in this PR, duplicates on the same connection are prevented. > > As mentioned before, this PR is useful since it fixes a race condition and returns ServiceNotReady in the case that the future completes after the check has been made (as explained in [#15051 (comment)](https://github.com/apache/pulsar/pull/15051#issuecomment-1092431543)). > > poorbarcode reopened this 1 hour ago > > > /pulsarbot run-failure-checks > > Please be aware of this: [apache/pulsar-test-infra#28 (comment)](https://github.com/apache/pulsar-test-infra/pull/28#issuecomment-1092079756) > > There shouldn't be a need to close & re-open the PR to rerun failed jobs. Please read the above explanations to understand what some failures are about. They don't need to clear off to be able to merge the PR. My point is wrong > > poorbarcode reopened this 1 hour ago > > > /pulsarbot run-failure-checks > > Please be aware of this: [apache/pulsar-test-infra#28 (comment)](https://github.com/apache/pulsar-test-infra/pull/28#issuecomment-1092079756) > > There shouldn't be a need to close & re-open the PR to rerun failed jobs. Please read the above explanations to understand what some failures are about. They don't need to clear off to be able to merge the PR. I point wrong -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
