nodece commented on code in PR #15084:
URL: https://github.com/apache/pulsar/pull/15084#discussion_r846606633
##########
pulsar-websocket/src/main/java/org/apache/pulsar/websocket/service/WebSocketProxyConfiguration.java:
##########
@@ -175,6 +176,63 @@
@FieldContext(doc = "TLS cert refresh duration (in seconds). 0 means
checking every new connection.")
private long tlsCertRefreshCheckDurationSec = 300;
+ /**** --- KeyStore TLS config variables. --- ****/
+ @FieldContext(
+ doc = "Enable TLS with KeyStore type configuration in broker"
+ )
+ private boolean tlsEnabledWithKeyStore = false;
+
+ @FieldContext(
+ doc = "TLS Provider for Specify the SSL provider for the broker
service: \n"
+ + "When using TLS authentication with CACert, the valid
value is either OPENSSL or JDK.\n"
+ + "When using TLS authentication with KeyStore, available
values can be SunJSSE, Conscrypt and etc."
+ )
+ private String tlsProvider = null;
+
+ @FieldContext(
+ doc = "TLS KeyStore type configuration in broker: JKS, PKCS12"
Review Comment:
```suggestion
doc = "TLS KeyStore type configuration in web service: JKS,
PKCS12"
```
##########
pulsar-websocket/src/main/java/org/apache/pulsar/websocket/service/WebSocketProxyConfiguration.java:
##########
@@ -175,6 +176,63 @@ public class WebSocketProxyConfiguration implements
PulsarConfiguration {
@FieldContext(doc = "TLS cert refresh duration (in seconds). 0 means
checking every new connection.")
private long tlsCertRefreshCheckDurationSec = 300;
+ /**** --- KeyStore TLS config variables. --- ****/
+ @FieldContext(
+ doc = "Enable TLS with KeyStore type configuration in broker"
+ )
+ private boolean tlsEnabledWithKeyStore = false;
+
+ @FieldContext(
+ doc = "TLS Provider for Specify the SSL provider for the broker
service: \n"
+ + "When using TLS authentication with CACert, the valid
value is either OPENSSL or JDK.\n"
+ + "When using TLS authentication with KeyStore, available
values can be SunJSSE, Conscrypt and etc."
+ )
+ private String tlsProvider = null;
+
+ @FieldContext(
+ doc = "TLS KeyStore type configuration in broker: JKS, PKCS12"
+ )
+ private String tlsKeyStoreType = "JKS";
+
+ @FieldContext(
+ doc = "TLS KeyStore path in broker"
Review Comment:
```suggestion
doc = "TLS KeyStore path in web service"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
