horizonzy commented on code in PR #15107:
URL: https://github.com/apache/pulsar/pull/15107#discussion_r847870425
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java:
##########
@@ -1419,40 +1428,38 @@ private ByteBuf processMessageChunk(ByteBuf
compressedPayload, MessageMetadata m
* Notify waiting asyncReceive request with the received message.
*
* @param message
+ * @return the message is enqueue incomingMessages.
*/
- void notifyPendingReceivedCallback(final Message<T> message, Exception
exception) {
- if (pendingReceives.isEmpty()) {
Review Comment:
Hi, I just review the code and felt that the judgment in this place might be
unnecessary, introducing the risk of thread races. I double checked, it's
single scheduled executor, not cause thread race.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
