Anonymitaet commented on code in PR #15064:
URL: https://github.com/apache/pulsar/pull/15064#discussion_r847899347
##########
site2/docs/io-jdbc-sink.md:
##########
@@ -15,16 +15,16 @@ The configuration of all JDBC sink connectors has the
following properties.
### Property
-| Name | Type|Required | Default | Description
-|------|----------|----------|---------|-------------|
-| `userName` | String|false | " " (empty string) | The username used to
connect to the database specified by `jdbcUrl`.<br><br>**Note: `userName` is
case-sensitive.**|
-| `password` | String|false | " " (empty string)| The password used to connect
to the database specified by `jdbcUrl`. <br><br>**Note: `password` is
case-sensitive.**|
-| `jdbcUrl` | String|true | " " (empty string) | The JDBC URL of the database
to which the connector connects. |
-| `tableName` | String|true | " " (empty string) | The name of the table to
which the connector writes. |
-| `nonKey` | String|false | " " (empty string) | A comma-separated list
contains the fields used in updating events. |
-| `key` | String|false | " " (empty string) | A comma-separated list contains
the fields used in `where` condition of updating and deleting events. |
-| `timeoutMs` | int| false|500 | The JDBC operation timeout in milliseconds. |
-| `batchSize` | int|false | 200 | The batch size of updates made to the
database. |
+| Name | Type | Required | Default | Description
|
+|-------------|--------|----------|--------------------|----------------------------------------------------------------------------------------------------------------------|
+| `userName` | String | false | " " (empty string) | The username used to
connect to the database specified by `jdbcUrl`.<br><br>**Note: `userName` is
case-sensitive.** |
+| `password` | String | false | " " (empty string) | The password used to
connect to the database specified by `jdbcUrl`. <br><br>**Note: `password` is
case-sensitive.** |
Review Comment:
same
##########
site2/docs/io-jdbc-sink.md:
##########
@@ -15,16 +15,16 @@ The configuration of all JDBC sink connectors has the
following properties.
### Property
-| Name | Type|Required | Default | Description
-|------|----------|----------|---------|-------------|
-| `userName` | String|false | " " (empty string) | The username used to
connect to the database specified by `jdbcUrl`.<br><br>**Note: `userName` is
case-sensitive.**|
-| `password` | String|false | " " (empty string)| The password used to connect
to the database specified by `jdbcUrl`. <br><br>**Note: `password` is
case-sensitive.**|
-| `jdbcUrl` | String|true | " " (empty string) | The JDBC URL of the database
to which the connector connects. |
-| `tableName` | String|true | " " (empty string) | The name of the table to
which the connector writes. |
-| `nonKey` | String|false | " " (empty string) | A comma-separated list
contains the fields used in updating events. |
-| `key` | String|false | " " (empty string) | A comma-separated list contains
the fields used in `where` condition of updating and deleting events. |
-| `timeoutMs` | int| false|500 | The JDBC operation timeout in milliseconds. |
-| `batchSize` | int|false | 200 | The batch size of updates made to the
database. |
+| Name | Type | Required | Default | Description
|
+|-------------|--------|----------|--------------------|----------------------------------------------------------------------------------------------------------------------|
+| `userName` | String | false | " " (empty string) | The username used to
connect to the database specified by `jdbcUrl`.<br><br>**Note: `userName` is
case-sensitive.** |
Review Comment:
```suggestion
| `userName` | String | false | " " (empty string) | The username used
to connect to the database specified by `jdbcUrl`.<br /><br />**Note:
`userName` is case-sensitive.** |
```
syntax:
https://docs.google.com/document/d/1IV35SI_F8G8cL-Vuzknc6RTGLK9_edRMpZpnrHvAWNs/edit#bookmark=id.wcmnciyvvq6p
##########
site2/docs/io-jdbc-sink.md:
##########
@@ -15,16 +15,16 @@ The configuration of all JDBC sink connectors has the
following properties.
### Property
-| Name | Type|Required | Default | Description
-|------|----------|----------|---------|-------------|
-| `userName` | String|false | " " (empty string) | The username used to
connect to the database specified by `jdbcUrl`.<br><br>**Note: `userName` is
case-sensitive.**|
-| `password` | String|false | " " (empty string)| The password used to connect
to the database specified by `jdbcUrl`. <br><br>**Note: `password` is
case-sensitive.**|
-| `jdbcUrl` | String|true | " " (empty string) | The JDBC URL of the database
to which the connector connects. |
-| `tableName` | String|true | " " (empty string) | The name of the table to
which the connector writes. |
-| `nonKey` | String|false | " " (empty string) | A comma-separated list
contains the fields used in updating events. |
-| `key` | String|false | " " (empty string) | A comma-separated list contains
the fields used in `where` condition of updating and deleting events. |
-| `timeoutMs` | int| false|500 | The JDBC operation timeout in milliseconds. |
-| `batchSize` | int|false | 200 | The batch size of updates made to the
database. |
+| Name | Type | Required | Default | Description
|
+|-------------|--------|----------|--------------------|----------------------------------------------------------------------------------------------------------------------|
+| `userName` | String | false | " " (empty string) | The username used to
connect to the database specified by `jdbcUrl`.<br><br>**Note: `userName` is
case-sensitive.** |
+| `password` | String | false | " " (empty string) | The password used to
connect to the database specified by `jdbcUrl`. <br><br>**Note: `password` is
case-sensitive.** |
+| `jdbcUrl` | String | true | " " (empty string) | The JDBC URL of the
database to which the connector connects.
|
+| `tableName` | String | true | " " (empty string) | The name of the table
to which the connector writes.
|
+| `nonKey` | String | false | " " (empty string) | A comma-separated
list contains the fields used in updating events.
|
Review Comment:
```suggestion
| `nonKey` | String | false | " " (empty string) | A comma-separated
list containing the fields used in updating events.
|
```
##########
site2/docs/io-jdbc-sink.md:
##########
@@ -15,16 +15,16 @@ The configuration of all JDBC sink connectors has the
following properties.
### Property
-| Name | Type|Required | Default | Description
-|------|----------|----------|---------|-------------|
-| `userName` | String|false | " " (empty string) | The username used to
connect to the database specified by `jdbcUrl`.<br><br>**Note: `userName` is
case-sensitive.**|
-| `password` | String|false | " " (empty string)| The password used to connect
to the database specified by `jdbcUrl`. <br><br>**Note: `password` is
case-sensitive.**|
-| `jdbcUrl` | String|true | " " (empty string) | The JDBC URL of the database
to which the connector connects. |
-| `tableName` | String|true | " " (empty string) | The name of the table to
which the connector writes. |
-| `nonKey` | String|false | " " (empty string) | A comma-separated list
contains the fields used in updating events. |
-| `key` | String|false | " " (empty string) | A comma-separated list contains
the fields used in `where` condition of updating and deleting events. |
-| `timeoutMs` | int| false|500 | The JDBC operation timeout in milliseconds. |
-| `batchSize` | int|false | 200 | The batch size of updates made to the
database. |
+| Name | Type | Required | Default | Description
|
+|-------------|--------|----------|--------------------|----------------------------------------------------------------------------------------------------------------------|
+| `userName` | String | false | " " (empty string) | The username used to
connect to the database specified by `jdbcUrl`.<br><br>**Note: `userName` is
case-sensitive.** |
+| `password` | String | false | " " (empty string) | The password used to
connect to the database specified by `jdbcUrl`. <br><br>**Note: `password` is
case-sensitive.** |
+| `jdbcUrl` | String | true | " " (empty string) | The JDBC URL of the
database to which the connector connects.
|
+| `tableName` | String | true | " " (empty string) | The name of the table
to which the connector writes.
|
+| `nonKey` | String | false | " " (empty string) | A comma-separated
list contains the fields used in updating events.
|
Review Comment:
or `A comma-separated list that contains the fields used in updating events`
##########
site2/docs/io-jdbc-sink.md:
##########
@@ -15,16 +15,16 @@ The configuration of all JDBC sink connectors has the
following properties.
### Property
-| Name | Type|Required | Default | Description
-|------|----------|----------|---------|-------------|
-| `userName` | String|false | " " (empty string) | The username used to
connect to the database specified by `jdbcUrl`.<br><br>**Note: `userName` is
case-sensitive.**|
-| `password` | String|false | " " (empty string)| The password used to connect
to the database specified by `jdbcUrl`. <br><br>**Note: `password` is
case-sensitive.**|
-| `jdbcUrl` | String|true | " " (empty string) | The JDBC URL of the database
to which the connector connects. |
-| `tableName` | String|true | " " (empty string) | The name of the table to
which the connector writes. |
-| `nonKey` | String|false | " " (empty string) | A comma-separated list
contains the fields used in updating events. |
-| `key` | String|false | " " (empty string) | A comma-separated list contains
the fields used in `where` condition of updating and deleting events. |
-| `timeoutMs` | int| false|500 | The JDBC operation timeout in milliseconds. |
-| `batchSize` | int|false | 200 | The batch size of updates made to the
database. |
+| Name | Type | Required | Default | Description
|
+|-------------|--------|----------|--------------------|----------------------------------------------------------------------------------------------------------------------|
+| `userName` | String | false | " " (empty string) | The username used to
connect to the database specified by `jdbcUrl`.<br><br>**Note: `userName` is
case-sensitive.** |
+| `password` | String | false | " " (empty string) | The password used to
connect to the database specified by `jdbcUrl`. <br><br>**Note: `password` is
case-sensitive.** |
+| `jdbcUrl` | String | true | " " (empty string) | The JDBC URL of the
database to which the connector connects.
|
+| `tableName` | String | true | " " (empty string) | The name of the table
to which the connector writes.
|
+| `nonKey` | String | false | " " (empty string) | A comma-separated
list contains the fields used in updating events.
|
+| `key` | String | false | " " (empty string) | A comma-separated
list contains the fields used in `where` condition of updating and deleting
events. |
Review Comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
