codelipenghui commented on code in PR #14723:
URL: https://github.com/apache/pulsar/pull/14723#discussion_r848102787
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistryService.java:
##########
@@ -42,10 +43,11 @@ static Map<SchemaType, SchemaCompatibilityCheck>
getCheckers(Set<String> checker
return checkers;
}
- static SchemaRegistryService create(SchemaStorage schemaStorage,
Set<String> schemaRegistryCompatibilityCheckers) {
+ static SchemaRegistryService create(SchemaStorage schemaStorage,
ServiceConfiguration configuration) {
Review Comment:
Do we need this change?
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistryServiceImpl.java:
##########
@@ -104,6 +108,8 @@ public CompletableFuture<SchemaAndMetadata>
getSchema(String schemaId, SchemaVer
((LongSchemaVersion)
schemaAndMetadata.version).getVersion() == longVersion)
.collect(Collectors.toList())
).thenCompose(metadataList -> {
+ log.debug("[{}] Meta data list size {}", schemaId,
+ CollectionUtils.isEmpty(metadataList) ? 0 :
metadataList.size());
Review Comment:
Add if (log.isDebugEnabled())
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
