merlimat commented on a change in pull request #3969: Cleanup temporary files 
created by functions
URL: https://github.com/apache/pulsar/pull/3969#discussion_r271498104
 
 

 ##########
 File path: 
pulsar-broker/src/test/java/org/apache/pulsar/io/PulsarFunctionE2ETest.java
 ##########
 @@ -450,6 +452,15 @@ private void testE2EPulsarFunction(String jarFilePathUrl) 
throws Exception {
         // make sure subscriptions are cleanup
         
assertEquals(admin.topics().getStats(sourceTopic).subscriptions.size(), 0);
 
+        // make sure all temp files are deleted
+        File dir = new File(System.getProperty("java.io.tmpdir"));
 
 Review comment:
   Maybe we could have a configurable directory for these download & test 
operation. Given that /tmp is most commonly mounted on tmpfs which is a 
ramdisk, we should allow users to configure a different directory that is 
disk-based (eg: using emptyDir on K8S)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to