mattisonchao commented on PR #15062:
URL: https://github.com/apache/pulsar/pull/15062#issuecomment-1097566849

   Hi @HQebupt 
   This issue's root cause looks like we add `msgRateIn` and `msgThroughputIn` 
status twice. the code is shown below:
   Position 1:
   
https://github.com/apache/pulsar/blob/a4c4aea993aabab5231d4136b7eba366bee9e778/pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/NamespaceStatsAggregator.java#L187-L194
   
   Position 2:
   
https://github.com/apache/pulsar/blob/a4c4aea993aabab5231d4136b7eba366bee9e778/pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/NamespaceStatsAggregator.java#L252-L265
   
   I think we can delete one and add a test to verify if the result is correct.
   Please let me know what you think, thanks.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to