liangyepianzhou commented on code in PR #15114:
URL: https://github.com/apache/pulsar/pull/15114#discussion_r849190477


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/TransactionMetadataStoreService.java:
##########
@@ -180,6 +180,8 @@ public CompletableFuture<Void> 
handleTcClientConnect(TransactionCoordinatorID tc
                         // so we should jude the store exist again.
                         if (stores.get(tcId) != null) {
                             completableFuture.complete(null);
+                            tcLoadSemaphore.release();
+                            return;
                         }

Review Comment:
   yes, If the store is already there, we can complete the future, and this 
means that this time handleTcClientConnect has completed. We should do nothing 
again. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to