horizonzy commented on code in PR #15144:
URL: https://github.com/apache/pulsar/pull/15144#discussion_r850000388
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ZeroQueueConsumerImpl.java:
##########
@@ -182,14 +182,20 @@ void
receiveIndividualMessagesFromBatch(BrokerEntryMetadata brokerEntryMetadata,
log.warn(
"Closing consumer [{}]-[{}] due to unsupported received
batch-message with zero receiver queue size",
subscription, consumerName);
- // close connection
- closeAsync().handle((ok, e) -> {
Review Comment:
This changes not about race conditions. It more like unify code.
notifyPendingReceivedCallback should in internalPinnedExecutor.
And fix the bad behavior: close consumer firstly, makes pendings receives
get inaccurate error info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
