Anonymitaet commented on code in PR #15177: URL: https://github.com/apache/pulsar/pull/15177#discussion_r852666496
########## site2/docs/developing-binary-protocol.md: ########## @@ -406,12 +406,19 @@ message CommandAck { ``` Parameters: - * `consumer_id` → Id of an already established consumer + * `consumer_id` → ID of an already established consumer * `ack_type` → Type of acknowledgment: `Individual` or `Cumulative` - * `message_id` → Id of the message to acknowledge + * `message_id` → ID of the message to acknowledge * `validation_error` → *(optional)* Indicates that the consumer has discarded the messages due to: `UncompressedSizeCorruption`, `DecompressionError`, `ChecksumMismatch`, `BatchDeSerializeError` + * `properties` -> *(optional)* Reserved configuration items + * `txnid_most_bits` -> *(optional)* Same as TC ID, `txnid_most_bits` and `txnid_least_bits` + uniquely identify a transaction. + * `txnid_least_bits` -> *(optional)* The id of the transaction opened in a TC, Review Comment: you miss this occurrence -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org