aparajita89 commented on code in PR #14102:
URL: https://github.com/apache/pulsar/pull/14102#discussion_r853812902
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -706,8 +707,9 @@ public void start() throws PulsarServerException {
this.startNamespaceService();
schemaStorage = createAndStartSchemaStorage();
- schemaRegistryService = SchemaRegistryService.create(
- schemaStorage,
config.getSchemaRegistryCompatibilityCheckers());
+ ensureSchemaRegistryName(schemaStorage);
Review Comment:
this was part of the existing logic. if schema storage is null then the
SchemaRegistryServiceDisabled needs to be used. otherwise,
SchemaRegistryServiceImpl needs to be used by default.
below is the expected behavior for each of the combinations for configs set
in broker's conf file.
* if schemaRegistryClassName == null and schemaRegistryStorageClassName ==
null then set schemaStorage to null and schemaRegistry to
SchemaRegistryServiceDisabled
* if schemaRegistryClassName != null and schemaRegistryStorageClassName ==
null then set schemaStorage to null and schemaRegistry to
SchemaRegistryServiceDisabled
* if schemaRegistryClassName == null and schemaRegistryStorageClassName !=
null then set schemaStorage to the configured object and schemaRegistry to
SchemaRegistryServiceImpl
* if schemaRegistryClassName != null and schemaRegistryStorageClassName !=
null then set schemaStorage to the configured object and schemaRegistry to the
configured object
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
