congbobo184 commented on code in PR #14102:
URL: https://github.com/apache/pulsar/pull/14102#discussion_r853827451
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -706,8 +707,9 @@ public void start() throws PulsarServerException {
this.startNamespaceService();
schemaStorage = createAndStartSchemaStorage();
- schemaRegistryService = SchemaRegistryService.create(
- schemaStorage,
config.getSchemaRegistryCompatibilityCheckers());
+ ensureSchemaRegistryName(schemaStorage);
Review Comment:
https://github.com/apache/pulsar/blob/caf7648653c140c9f922e86425585ab7b5ed3ed6/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java#L1303
in this code, createAndStartSchemaStorage will not create a schemaStorage is
null. so why we should check ensureSchemaRegistryName and set default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
