samuelhewitt opened a new pull request, #762:
URL: https://github.com/apache/pulsar-client-go/pull/762
Add tests for producer schema encode.
### Motivation
When using Producer, if the ProducerMessage.Value fails to encode using the
producer's Schema, the code never returns when using `producer.Send()` and
never executes the callback when using `producer.SendAsync()`. Additionally,
the publishSemaphore that was Acquired is never released.
### Modifications
When an error is returned by Schema Encode, release the Semaphore and
execute the callback.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change added tests and can be verified as follows:
- *Added integration test with failure to encode schema*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): no
- The public API: no
- The schema: no
- The default values of configurations: no
- The wire protocol: no
### Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
