poorbarcode commented on code in PR #15241:
URL: https://github.com/apache/pulsar/pull/15241#discussion_r855114449
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -1432,9 +1434,7 @@ public void openLedgerComplete(ManagedLedger ledger,
Object ctx) {
if
(topicFuture.isCompletedExceptionally()) {
log.warn("{} future is already
completed with failure {}, closing the"
+ " topic", topic,
FutureUtil.getException(topicFuture));
-
persistentTopic.stopReplProducers().whenComplete((v, exception) -> {
Review Comment:
In original implements, It ensures that
`persistentTopic.stopReplProducers()` executes before `topics.remove(...)`,
this ensures that "there are no multiple threads change one topic"
After this change, this advantage was deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
