srkukarni commented on a change in pull request #3980: fix: bug when function
auth is not enabled
URL: https://github.com/apache/pulsar/pull/3980#discussion_r272273881
##########
File path:
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionActioner.java
##########
@@ -153,9 +153,13 @@ RuntimeSpawner getRuntimeSpawner(Function.Instance
instance, String packageFile)
int instanceId = instance.getInstanceId();
FunctionDetails.Builder functionDetailsBuilder =
FunctionDetails.newBuilder(functionMetaData.getFunctionDetails());
+
+ Function.FunctionAuthenticationSpec functionAuthenticationSpec
+ = instance.getFunctionMetaData().hasFunctionAuthSpec()
Review comment:
Not sure if will fix the issue. Because as i see it,
instance.getFunctionmetaData().hasFunctionAuthSpec() will always be true. The
thing is that the condition check inside componentImpl who sets this is not
right imo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
